-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not globally generate typings #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, such things are project specific
If we were going to turn it off here we should also turn it on in the appropriate subprojects (e.g. It seems like a better default to generate the types though. Then there always available if you want to use them and I don't really see any downside to generating them. Is there some con to doing it that I'm overlooking? The netlify output was strange not just for the types but for the actual The output dir is ignored by default but will be used if you set |
The con is mostly that you get empty |
Oh, and about |
Yeah Removing the |
I sent #167 to remove |
Having a common
tsconfig
is great, but I don't believe it should turn on typings generation by default. For the adapters the outcome is generally not what we want. For example, the Netlify adapter puts the typings ofrender.ts
into anindex.d.ts
that is next to an unrelatedindex.js
. (I notice this is fixed by #138, but anyway, I don't think it's a reasonable default)So I think we'd better turn it off on a global level and activate it in the subprojects where we actually support it.
As for
declarationDir
it seems to be ignored by the rollup typescript plugin.